Optimized BFV/BFV operations involving plaintexts #730
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dsuponitskiy
reviewed
Apr 5, 2024
| // ilVector coefficients are packed and resulting ilVector is in | ||
| // COEFFICIENT form. | ||
| this->Pack(&this->GetElement<NativePoly>(), this->encodingParams->GetPlaintextModulus()); | ||
| // Calls the inverse NTT mod plaintext modulus |
There was a problem hiding this comment.
Can the code below (lines 90, 92-95) be executed first in this block? Also 2 brackets around OPENFHE_THROW should improve readability.
There was a problem hiding this comment.
The branches are quite different and work with different data members (encodedNativeVector vs encodedVectorDCRT). I do not think it is a good idea to merge them. The code will be hard to read and follow.
Sure, feel free to add the extra brackets around OPENFHE_THROW
| } | ||
| else { | ||
| // Calls the inverse NTT mod plaintext modulus |
There was a problem hiding this comment.
Can the code below (lines 102-107) be executed first in this block? Also 2 brackets around OPENFHE_THROW should improve readability.
There was a problem hiding this comment.
Sure, please add extra parentheses around OPENFHE_THROW
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The runtime of ctxt/ptxt is now 1.5-3x faster than before (depending on the machine used for measurements). The packing now takes more time because it calls NTTs at the end rather than during subsequent ctxt/ptxt operations.