-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
New slash syntax in parameters is not supported #169
Comments
The problem seems to be due to the /parameters page --> This parameter list defines the routing of the LegExp. When we changed the key from "cotsoc.gen.smic_h_b" to "cotsoc/gen/smic_h_b", the routing module looks for a parameter called "cotsoc" and doesn't find it.
I hope this will help :) |
Humm, all the side-effect on You're right, let's roll back and see what we do next. |
Roll back is done, and there is now a v22 api with the new core available for tests :) |
Currently, the legislation explorer is still not compatible with the latest version of Core. Until this is fixed, this issue should probably stay open. |
Fixed by openfisca/openfisca-core#710 |
As shown in https://saucelabs.com/jobs/56e91565aad14feb98de97c7862b9e19, the new slash syntax for parameters introduced in some new version of the web API breaks the legislation explorer. It prevents the router from loading the page altogether.
This is a major problem for the Legislation Explorer as its integration tests are currently based on the French API, and @openfisca/france-admin have deployed this latest version live, which means that all tests will now fail, preventing merges.
This new slash syntax should be supported, as it is apparently the new way to navigate parameters.
This also underlines the need to isolate tests from any live environment.
The text was updated successfully, but these errors were encountered: