Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add date units to periods #1139

Closed
wants to merge 71 commits into from
Closed

Add date units to periods #1139

wants to merge 71 commits into from

Conversation

bonjourmauko
Copy link
Member

@bonjourmauko bonjourmauko commented Jul 29, 2022

Depends on #1138

Thanks for contributing to OpenFisca! Remove this line, as well as any other in the following that don't fit your contribution :)

New features

  • Introduce DateUnit to periods
    • Allows for transparent encapsulation of the atomic units of periods (year, month, ...).
    • This helps with testing, refactoring and exrtension of periods (weeks for example).

@bonjourmauko bonjourmauko added the kind:solution A feature request, a feature deprecation label Jul 29, 2022
@coveralls
Copy link

Coverage Status

Coverage increased (+0.7%) to 79.676% when pulling f51fc62 on add-date-units into 3eb157f on master.

@benjello
Copy link
Member

Looks nice @maukoquiroga.

@bonjourmauko bonjourmauko marked this pull request as draft July 30, 2022 15:44
@bonjourmauko bonjourmauko force-pushed the add-date-units branch 3 times, most recently from 9fc0e3e to 2cb935c Compare July 31, 2022 14:37
@bonjourmauko
Copy link
Member Author

Superseded by #1138

@bonjourmauko bonjourmauko deleted the add-date-units branch December 19, 2022 11:00
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
kind:solution A feature request, a feature deprecation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants