Fix cotsoc noncontrib #571
Conversation
| @@ -1,5 +1,10 @@ | |||
| # Changelog | |||
|
|
|||
| ## 4.1.12 | |||
|
|
|||
| * Rename cotsoc_noncontrib to cotisations_non_contributives | |||
There was a problem hiding this comment.
You should also do that with cotsoc_contrib etc.
Look for all these badly named cotosoc_* ;-)
There was a problem hiding this comment.
So this will be a larger pull request, but OK
There was a problem hiding this comment.
There are only cotsoc_bar_declarant1 and cotsoc_lib_declarant1 remaining. How should I rename them?
|
I will deal with those ! |
cbenz
force-pushed
the
fix-cotsoc-noncontrib
branch
from
b5d83f0
to
f27c817
Compare
|
@benjello OK but since the renames lead to a Major Bump (4.1.11 => 5.0.0) I prefer keeping this PR opened and let you take your time to add commits in the branch of the PR ( Then we'll merge it. |
|
@fpagnoux : i need to merge this one ASAP too ;-) |
|
Good for me, but we had recently a lot of major releases for just a few renamings. I would prefer if they were grouped in one PR. But maybe I'm being to attached to version number, @MattiSG your thoughts ? |
|
Should we wait for MattiSG to merge this ? |
|
Don't be romantic about versioning. It's nice to bundle changes, but don't do it at the cost of delaying delivery. As long as the changelog is clear, the clients can adapt their own update pace and do several versions at once. |
|
If we plan a bit more, we'll make these changes more meaningful. |
From #570