This repository has been archived by the owner on May 15, 2018. It is now read-only.
Revert "Use calculate_add_divide instead of calculate in "formula" controller." #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ntroller." This reverts commit a4f86c7. Makes /formula crash on input variables with error 'Holder' object has no attribute 'period'
|
Nope, this has been merged in #17. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The reverted change makes /formula crash on input variables with error
'Holder' object has no attribute 'period'. Could you explain what's the rationale for changing this function, and how we can avoid this error?This reverts commit a4f86c7.