Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Lime's version of the class has fallen behind Haxe's over time, and I believe it's past time to return to using their version. Shadowing a core class should always be a last resort.
Lime does add a few things to the class, so we want to make sure we can still get the same functionality.
@:autoBuild
metadata to enable asset embedding. I usedCompiler.addMetadata()
to achieve the same.lime_bytes_length_getter
flag to allow settinglength
. This appears to be used by openfl-js, though there are other ways to achieve the same thing, so I submitted MakeByteArray
compatible with Haxe'sBytes
class. openfl#2692.& 0xFF
operations. The Haxe devs have gone on record saying this isn't needed, so I left them out.#if cpp
with#if (cpp || webassembly)
. Edit: this is redundant, because thecpp
flag is set when targeting WebAssembly. I left it out.I checked line by line in a diff editor to make sure that was everything. All other differences either had no functional effect (whitespace and so on), or were because Haxe's version was newer.