Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Implemented support for changing resolutions and going fullscreen. #4

Merged
merged 1 commit into from
Feb 10, 2014
Merged

Implemented support for changing resolutions and going fullscreen. #4

merged 1 commit into from
Feb 10, 2014

Conversation

RobDangerous
Copy link
Contributor

For the accompanying openfl-native pull-request.
One problem remains: Something calls SDL2Stage::SetScreenMode repeatedly, seemingly in response to mouse events. Don't know how that happens, added a small hack to ignore those calls.

@Ephiarsis
Copy link

Hey there, I've been messing around with your additions a bit but couldn't get it running. Is it possible to use lime with your extensions to control the fullscreen settings for an otherwise pure openfl-project?

Falls Du Dich dort auskennst würde ich etwas Hilfe in der Richtung sehr zu schätzen wissen. Ich versuche seit Monaten ein Problem in meinem Projekt zu lösen und bekomme es nicht hin. Würde mich freuen, wenn Du nen Augenblick Zeit hättest.

@RobDangerous
Copy link
Contributor Author

Yes, that's possible. Will contact you on skype to figure out what's going wrong.

jgranick added a commit that referenced this pull request Feb 10, 2014
Implemented support for changing resolutions and going fullscreen.
@jgranick jgranick merged commit 344cda9 into openfl:master Feb 10, 2014
@jgranick
Copy link
Member

Hey Rob, thanks again for your patience.

You've done a great job of making sure that this is done in a way that doesn't impact the existing behavior. You've enabled something that is not otherwise possible right now.

I'm not sure if this will remain permanent, but if it does not, it will be because we've merged this functionality in a slightly different way.

I really appreciate your help, and hope that we won't let useful changes like this block in the future. Have a great day!

@RobDangerous
Copy link
Contributor Author

Thanks, always glad to help.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants