fix offset math in ColorTransform.concat #2653
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
in this thread Thomas outlined the expected offset formula:
Joshua replied that it was implemented, however the formula used was:
the doc states
but the previous code has this backwards
Came across this when I was implementing flixel tools for adobe animate's tint and brightness color transforms, I noticed that concatenating a full brightness or full tint on top of another transform did not completely override the initial transforms values.