Change to use pure golang sqlite driver for better portability #564
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nothing0012
commented
Jan 1, 2024
| @@ -3,7 +3,6 @@ package entity | |||
| import ( | |||
| "github.com/openflagr/flagr/swagger_gen/models" | |||
|
|
|||
| _ "gorm.io/driver/sqlite" // sqlite driver | |||
There was a problem hiding this comment.
this was already imported and used in db.go
nothing0012
commented
Jan 1, 2024
| @@ -56,13 +55,12 @@ require ( | |||
|
|
|||
| require ( | |||
| cloud.google.com/go/pubsub v1.30.0 | |||
| github.com/goccy/go-json v0.10.2 | |||
There was a problem hiding this comment.
go-json was not used.
running make vendor to tidy this
Codecov ReportAttention:
❗ Your organization needs to install the Codecov GitHub app to enable full functionality. Additional details and impacted files@@ Coverage Diff @@
## main #564 +/- ##
=======================================
Coverage 81.18% 81.18%
=======================================
Files 28 28
Lines 2270 2270
=======================================
Hits 1843 1843
Misses 337 337
Partials 90 90 ☔ View full report in Codecov by Sentry. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Update the sqlite dep to be golang only, this helps the portability and reduce the dependency on cgo
Tests and Benchmark of the new sqlite3 driver:
Motivation and Context
How Has This Been Tested?
Types of changes
Checklist: