Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Adding a Knowledge Panel for data-quality #10

Merged
merged 22 commits into from
Jul 29, 2022
Merged

feat: Adding a Knowledge Panel for data-quality #10

merged 22 commits into from
Jul 29, 2022

Conversation

sumit-158
Copy link
Member

@sumit-158 sumit-158 commented Jul 16, 2022 •
edited
Loading

What

  • Added a knowledge panel for data-quality

Fixes bug(s)

@sumit-158 sumit-158 linked an issue Jul 16, 2022 that may be closed by this pull request
Knowledge panel for data quality facet #9
Closed
@sumit-158 sumit-158 marked this pull request as ready for review July 16, 2022 16:05
teolemon
teolemon reviewed Jul 16, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
teolemon
teolemon reviewed Jul 16, 2022
View reviewed changes
tests/test_main.py Outdated Show resolved Hide resolved
teolemon
teolemon reviewed Jul 16, 2022
View reviewed changes
tests/test_main.py Outdated Show resolved Hide resolved
teolemon
teolemon reviewed Jul 16, 2022
View reviewed changes
tests/test_main.py Outdated Show resolved Hide resolved
@sumit-158 sumit-158 requested a review from teolemon July 17, 2022 11:12
alexgarel
alexgarel reviewed Jul 20, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 20, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 20, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 20, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 20, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 20, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
sumit-158
sumit-158 commented Jul 20, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 23, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@sumit-158 some comments that should help you

app/knowledge_panels.py Outdated Show resolved Hide resolved
app/knowledge_panels.py Outdated Show resolved Hide resolved
app/knowledge_panels.py Outdated Show resolved Hide resolved
app/knowledge_panels.py Outdated Show resolved Hide resolved
tests/test_knowledge_panels.py Outdated Show resolved Hide resolved
tests/test_knowledge_panels.py Outdated Show resolved Hide resolved
@sumit-158 sumit-158 requested a review from alexgarel July 24, 2022 08:43
alexgarel
alexgarel reviewed Jul 26, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel requested changes Jul 26, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @sumit-158 this is a good work but I'm a bit exigent ;-)

app/knowledge_panels.py Outdated Show resolved Hide resolved
app/knowledge_panels.py Outdated Show resolved Hide resolved
app/knowledge_panels.py Outdated Show resolved Hide resolved
app/knowledge_panels.py Outdated Show resolved Hide resolved
app/knowledge_panels.py Outdated Show resolved Hide resolved
app/knowledge_panels.py Outdated Show resolved Hide resolved
app/main.py Outdated Show resolved Hide resolved
tests/test_knowledge_panels.py Outdated Show resolved Hide resolved
tests/test_main.py Outdated Show resolved Hide resolved
tests/test_knowledge_panels.py Outdated Show resolved Hide resolved
@sumit-158 sumit-158 requested a review from alexgarel July 26, 2022 15:52
@sumit-158 sumit-158 requested a review from alexgarel July 28, 2022 11:05
@sumit-158
Copy link
Member Author

@alexgarel can you please review it?

@sumit-158 sumit-158 mentioned this pull request Jul 29, 2022
Closed
alexgarel
alexgarel requested changes Jul 29, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Close but some changes to be done !

tests/test_knowledge_panels.py Outdated Show resolved Hide resolved
tests/test_knowledge_panels.py Outdated Show resolved Hide resolved
tests/test_knowledge_panels.py Outdated Show resolved Hide resolved
tests/test_knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 29, 2022
View reviewed changes
app/knowledge_panels.py Outdated Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 29, 2022
View reviewed changes
app/off.py Show resolved Hide resolved
alexgarel
alexgarel reviewed Jul 29, 2022
View reviewed changes
app/models.py Outdated Show resolved Hide resolved
alexgarel
alexgarel approved these changes Jul 29, 2022
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

🎉 @sumit-158

Just move tidy_html to test_utils.py and there we are :-)

@sumit-158 sumit-158 merged commit 6ed0135 into main Jul 29, 2022
@sumit-158 sumit-158 deleted the knowledge_panel_for_data_quality branch July 29, 2022 14:44
@github-actions github-actions bot mentioned this pull request Sep 23, 2022
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

@teolemon teolemon Awaiting requested review from teolemon

Assignees

@sumit-158 sumit-158

Labels
None yet
Projects
Knowledge Panels for Facets
Status: ✅ Done
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Knowledge panel for data quality facet
3 participants
@sumit-158 @alexgarel @teolemon