refactor(l10n): allow translation of filtering options (#411)

openfoodfacts · Mar 6, 2024 · c013a76 · c013a76
1 parent 4ea4387
commit c013a76
Show file tree

Hide file tree

Showing 8 changed files with 10 additions and 8 deletions.
diff --git a/src/constants.js b/src/constants.js
@@ -9,10 +9,10 @@ export default {
   PRODUCT_QUANTITY_UNIT_ML: 'ml',
   FILTER_PARAM: 'filter',
   PRODUCT_FILTER_LIST: [
-    { key: 'hide_price_count_gte_1', value: 'Hide products with prices' },
+    { key: 'hide_price_count_gte_1', value: 'FilterProductWithPriceCountHide' },
   ],
   PRICE_FILTER_LIST: [
-    { key: 'only_last_30d', value: 'Only prices for the last 30 days' },
+    { key: 'only_last_30d', value: 'FilterPriceMoreThan30DaysHide' },
   ],
   ORDER_BY_PARAM: 'order_by',
   PRODUCT_ORDER_BY_LIST: [

diff --git a/src/i18n/locales/en.json b/src/i18n/locales/en.json
@@ -108,6 +108,8 @@
 	"Common": {
 		"AddToOFF": "Add to {name}",
 		"Filter": "Filter",
+		"FilterProductWithPriceCountHide": "Hide products with prices",
+		"FilterPriceMoreThan30DaysHide": "Hide prices older than 30 days",
 		"Order": "Order",
 		"OrderProductUniqueScansDESC": "Number of scans",
 		"OrderProductPriceCountDESC": "Number of prices",

diff --git a/src/views/BrandDetail.vue b/src/views/BrandDetail.vue
@@ -36,7 +36,7 @@
         </template>
         <v-list>
           <v-list-item :slim="true" v-for="filter in productFilterList" :key="filter.key" :prepend-icon="(productFilter === filter.key) ? 'mdi-check-circle' : 'mdi-circle-outline'" :active="productFilter === filter.key" @click="toggleProductFilter(filter.key)">
-            {{ filter.value }}
+            {{ $t('Common.' + filter.value) }}
           </v-list-item>
         </v-list>
       </v-menu>

diff --git a/src/views/CategoryDetail.vue b/src/views/CategoryDetail.vue
@@ -36,7 +36,7 @@
         </template>
         <v-list>
           <v-list-item :slim="true" v-for="filter in productFilterList" :key="filter.key" :prepend-icon="(productFilter === filter.key) ? 'mdi-check-circle' : 'mdi-circle-outline'" :active="productFilter === filter.key" @click="toggleProductFilter(filter.key)">
-            {{ filter.value }}
+            {{ $t('Common.' + filter.value) }}
           </v-list-item>
         </v-list>
       </v-menu>

diff --git a/src/views/LocationDetail.vue b/src/views/LocationDetail.vue
@@ -39,7 +39,7 @@
         </template>
         <v-list>
           <v-list-item :slim="true" v-for="filter in priceFilterList" :key="filter.key" :prepend-icon="(priceFilter === filter.key) ? 'mdi-check-circle' : 'mdi-circle-outline'" :active="priceFilter === filter.key" @click="togglePriceFilter(filter.key)">
-            {{ filter.value }}
+            {{ $t('Common.' + filter.value) }}
           </v-list-item>
         </v-list>
       </v-menu>

diff --git a/src/views/ProductDetail.vue b/src/views/ProductDetail.vue
@@ -45,7 +45,7 @@
         </template>
         <v-list>
           <v-list-item :slim="true" v-for="filter in priceFilterList" :key="filter.key" :prepend-icon="(priceFilter === filter.key) ? 'mdi-check-circle' : 'mdi-circle-outline'" :active="priceFilter === filter.key" @click="togglePriceFilter(filter.key)">
-            {{ filter.value }}
+            {{ $t('Common.' + filter.value) }}
           </v-list-item>
         </v-list>
       </v-menu>

diff --git a/src/views/ProductList.vue b/src/views/ProductList.vue
@@ -15,7 +15,7 @@
         </template>
         <v-list>
           <v-list-item :slim="true" v-for="filter in productFilterList" :key="filter.key" :prepend-icon="(productFilter === filter.key) ? 'mdi-check-circle' : 'mdi-circle-outline'" :active="productFilter === filter.key" @click="toggleProductFilter(filter.key)">
-            {{ filter.value }}
+            {{ $t('Common.' + filter.value) }}
           </v-list-item>
         </v-list>
       </v-menu>

diff --git a/src/views/UserDetail.vue b/src/views/UserDetail.vue
@@ -31,7 +31,7 @@
         </template>
         <v-list>
           <v-list-item :slim="true" v-for="filter in priceFilterList" :key="filter.key" :prepend-icon="(priceFilter === filter.key) ? 'mdi-check-circle' : 'mdi-circle-outline'" :active="priceFilter === filter.key" @click="togglePriceFilter(filter.key)">
-            {{ filter.value }}
+            {{ $t('Common.' + filter.value) }}
           </v-list-item>
         </v-list>
       </v-menu>