Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Raw / bulk products: add missing categories #262

Open
raphodn opened this issue Jan 30, 2024 · 12 comments · Fixed by #305
Open

Raw / bulk products: add missing categories #262

raphodn opened this issue Jan 30, 2024 · 12 comments · Fixed by #305

Comments

@raphodn
Copy link
Member

raphodn commented Jan 30, 2024

Story

Following #30 & #87

https://raw.githubusercontent.com/openfoodfacts/openfoodfacts-server/main/taxonomies/food/categories.txt

Some categories in the price category choices are missing :

  • brocoli, chou fleur ?
  • meat
  • eggs
  • fish...

And some categories need to be removed :

  • canned
  • frozen
@raphodn raphodn changed the title Add missing categories Raw products: add missing categories Feb 6, 2024
@raphodn raphodn linked a pull request Feb 8, 2024 that will close this issue
@raphodn
Copy link
Member Author

raphodn commented Apr 18, 2024

  • patate douce
  • butternut
  • botte de radis, barquette de fraises, ail tressé
  • tomates coeur de boeuf
  • shiitake

@raphodn
Copy link
Member Author

raphodn commented Apr 30, 2024

problem with typeahead and accents

@serpico
Copy link

serpico commented May 30, 2024

  • foie de poulet , while there might be an EAN when it's prepackeged the quantity always vary slightly so input the price par quantity seems more appropriate
  • saucisses savoyardes
  • saucisses au roquefort
  • saucisses piment / saucisses au piment
  • saucisses aux herbes
  • saucisses chèvre miel
  • merguez
  • chipolatas
  • chair à saucisse
  • chair à tomate
  • pommes de terre louisiana

edit: after reading raphodn's explanations here it feels like an overkill to include all https://world.openfoodfacts.org/category/prepared-meats which seems to match most of the cases I mentioned here ( provided a few items would be added to the taxonomy ) but then it would be true as well for many cheeses when some user buying his cheeses à la coupe will dive into O-P - for the foreseeable future I'm ok waiting until O-P get's a little bit more integrated with the smooth-app.

@aleene
Copy link

aleene commented May 31, 2024

I assume these are missing from the selection on Prices. We could add a special parent category to the taxonomy for products that are sold per weight (fresh vegetables, etc,) and individually (croissant, baguette, hot coffee, etc). And where weight is more appropriate (EAN with multiple weight/prices).

@serpico
Copy link

serpico commented May 31, 2024

Is there a way to displays all the available types of pomme de terre/pommes de terre regardless of which one of those 2 spellings the user type ? Currently :

  • pommes de terre displays 14 variations/choices
  • pomme de terre displays 5 variations/choices

@raphodn
Copy link
Member Author

raphodn commented May 31, 2024

fyi the current list of categories is here (a folder, with 1 file per language code)
https://github.com/openfoodfacts/open-prices-frontend/tree/master/src/data/categories

it is generated after running this script
https://github.com/openfoodfacts/open-prices-frontend/blob/master/data/categories/filter_categories.py
see PR #273 for more details

for filtering we use this Vuetify component
https://vuetifyjs.com/en/components/autocompletes/
not sure if it manages "fuzzy" search easily

@raphodn
Copy link
Member Author

raphodn commented Jun 6, 2024

List of root categories (nodes without parents)

en:fresh-foods
en:stuffing
en:mountain-products
en:breaded-products
en:bread-coverings
en:snacks
en:cocoa-and-its-products
en:plant-based-foods-and-beverages
en:specific-products
fr:premier-cru
en:syrups
fr:de-matieres-grasses
en:meats-and-their-products
en:caviar-substitutes
ru:молоко-питьевое-с-массовой-долей-жира-от-4-7-до-7-0-ультрапастеризованное
en:pasteurised
en:sweet-pies
en:canned-foods
en:sweeteners
en:cooking-helpers
en:food-decorations
fi:hapatettu
fi:hapatetut
en:condiments
fr:poulet-crudites
ru:икра-овощная
en:pies
en:fried-foods
en:desserts
en:baby-foods
en:farming-products
en:freeze-dried-foods
en:brick-sheets
en:broths
en:bee-products
en:artisan-products
en:seafood
fr:conserve
fi:ruoat
en:skewers
en:chips-and-fries
en:meal-kits
en:meat-alternatives
en:frozen-foods
en:flavoured
en:dietary-supplements
en:breakfasts
en:fish-and-meat-and-eggs
en:fats
en:terrines
en:crepes-and-galettes
en:purees
en:spreads
en:capsules
en:dried-products
en:fermented-foods
en:festive-foods
ru:молоко-питьевое-с-массовой-долей-жира-от-4-7-до-7-0
fr:thon-crudites
en:dairies
en:meals
en:unpasteurised
en:hash-browns
en:refrigerated-foods
en:sandwich-made-with-french-bread
en:non-food-products
en:frozen-fruits-with-added-sugar
en:food-additives
en:sandwiches
en:beverages

@aleene
Copy link

aleene commented Jun 6, 2024

Thanks for the list. I will relove some.

@aleene
Copy link

aleene commented Jun 6, 2024

The list has many errors as the synonyms have been included.

@raphodn
Copy link
Member Author

raphodn commented Jun 6, 2024

Fyi i put this list for information, but the script that filters the categories only selects a subset of these. So in the Prices app there isn't as many categories thankfully :)

@aleene
Copy link

aleene commented Jun 6, 2024

I could add the parameter sales-format to entries in the category taxonomy. This could have values package, item or weight. The parameter is inheritable, so at a node, implies all children have the same values. A child could overrule maybe. I could start adding these based on the categories you already identified.

@raphodn
Copy link
Member Author

raphodn commented Jun 6, 2024

@raphodn raphodn changed the title Raw products: add missing categories Raw / bulk products: add missing categories Jun 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Backlog
Development

Successfully merging a pull request may close this issue.

4 participants