Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(products): display categories & labels count #367

Merged
merged 2 commits into from
Feb 23, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Feb 21, 2024

What

Thanks to the new fields in the backend, we can start displaying a badge with the count

Screenshot

Before After
image image

Copy link
Collaborator

@dq18 dq18 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everything is fine, we will need a chip cleanup / reorder / redesign eventually

@raphodn
Copy link
Member Author

raphodn commented Feb 22, 2024

Thanks for the review, I'll merge once we actually have data in these fields.
Currently they seem empty...
Example : https://prices.openfoodfacts.org/api/v1/products?page=1&size=10&order_by=-price_count

edit : fixed, data is now synced :)

@raphodn raphodn merged commit 648b8f2 into master Feb 23, 2024
4 checks passed
@raphodn raphodn deleted the raphodn/product-category-label-count branch February 23, 2024 15:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants