Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: new proof detail page #375

Merged
merged 5 commits into from
Feb 27, 2024
Merged

feat: new proof detail page #375

merged 5 commits into from
Feb 27, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Feb 24, 2024

What

Thanks to openfoodfacts/open-prices#228 & following #383

Allow users to view more details about their proofs, in a dedicated page

  • the proof image & basic info
  • the list of prices associated

Link is done via the proof price count chip.

An error message is shown is the proof is not found or not the owner

Why

See prices filtered by a given proof, allow in the future to add a new price for this proof

Screenshot

Existing proof Unknown proof
image image

Todo (future PRs)

@dq18
Copy link
Collaborator

dq18 commented Feb 26, 2024

proofPriceList of ProofDetail is not updated at price removal unless a new API call is made

@raphodn
Copy link
Member Author

raphodn commented Feb 27, 2024

proofPriceList of ProofDetail is not updated at price removal unless a new API call is made

I tested and the price div is effectively removed, though indeed there is no action on the proofPriceList : same behavior as all other price lists, until we implement an equivalent of #328 ? But that will be addressed in another PR, no ?

Copy link
Collaborator

@ArturLange ArturLange left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@dq18
Copy link
Collaborator

dq18 commented Feb 27, 2024

proofPriceList of ProofDetail is not updated at price removal unless a new API call is made

I tested and the price div is effectively removed, though indeed there is no action on the proofPriceList : same behavior as all other price lists, until we implement an equivalent of #328 ? But that will be addressed in another PR, no ?

I think you mean the store system in #376 ? And yes, it will be addressed in another PR

@dq18 dq18 merged commit 4f11bea into master Feb 27, 2024
3 checks passed
@dq18 dq18 deleted the raphodn/proof-detail-page branch February 27, 2024 17:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants