Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(proof): add the price CTA button in the proof detail page #557

Merged
merged 1 commit into from
Apr 25, 2024

Conversation

raphodn
Copy link
Member

@raphodn raphodn commented Apr 25, 2024

What

Following #375 & #521

Add the "Add price" CTA button on the proof detail page

Stuff missing

  • doesn't fetch the proof image
  • doesn't check if the user is the proof owner (but the CTA button is only displayed on pages where the user is owner of the proof, and it will have an error in the backend anyway)

Screenshot

image

@raphodn raphodn merged commit dface48 into master Apr 25, 2024
5 checks passed
@raphodn raphodn deleted the raphodn/feat-proof-detail-add-price branch April 25, 2024 15:34
@odin-h
Copy link
Collaborator

odin-h commented Apr 25, 2024

Does it need to check if the user is the owner of the proof image? What if someone who's not the owner sees a price tag in the image that the original uploader forgot to add?

@raphodn
Copy link
Member Author

raphodn commented Apr 25, 2024

Does it need to check if the user is the owner of the proof image? What if someone who's not the owner sees a price tag in the image that the original uploader forgot to add?

Currently, the backend server expects that both the price owner and the proof owner should be the same (except if they are moderators, but we don't use this feature yet in the frontend).

@odin-h
Copy link
Collaborator

odin-h commented Apr 26, 2024

Oh, okay 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

2 participants