feat: Category translation #261
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
raphodn
reviewed
Jan 30, 2024
| if (newVal && newVal.length > 0) { | ||
| this.category_loading = true | ||
| api | ||
| .getCategories(newVal, 'category', 10) |
There was a problem hiding this comment.
on every new price(s) we fetch the categories ? this isn't ideal 😅
- we could fetch them when the language is changed in the user settings (and put them in the store)
- we could have the translations directly in the raw json
There was a problem hiding this comment.
maybe document some implementation solutions first in the corresponding issue ? #224
There was a problem hiding this comment.
Here the API is called:
- once at page mount (with a simple query "a")
- Everytime the user inputs something in autocomplete field. So for example if the user type "rad", it will call for "r", then "ra" and "rad"
The fetch returns a list of max 10 categories (max number can be changed) and this list will be shown in the autocomplete field.
I will list solutions in the issue
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What