Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: new ordering choice by price (lowest first) #408

Merged
merged 2 commits into from
Mar 6, 2024
Merged

feat: new ordering choice by price (lowest first) #408

Changes from 1 commit
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
fd10001
Add new order by price (cheapest first)
raphodn Mar 6, 2024
79cf61c
Change icon. simplify wording
raphodn Mar 6, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion src/constants.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,8 +20,9 @@ export default {
{ key: '-price_count', value: 'Number of prices', icon: 'mdi-tag-multiple-outline' },
],
PRICE_ORDER_BY_LIST: [
{ key: '-created', value: 'Addition date', icon: 'mdi-clock-outline' },
{ key: 'price', value: 'Price (cheapest first)', icon: 'mdi-currency-eur' },
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would put "Price: ascending order" as I have seen on several marketplace.
Also, would put another icon, as euro is not relevant outside EU. Maybe order-numeric-ascending, since I'm sure the descending option will come soon :)

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good idea for the icon 👍

Copy link
Member Author

@raphodn raphodn Mar 6, 2024 •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

any screenshots for the wording ? ascending is too technical i think

Image
Vinted image
Amazon image
Ebay image
Etsy image

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'll change to just "Price", and we can open an issue to figure out the best wording :)

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hmm true, my bad. I rarely go to marketplaces and when I do they are in German with autotranslation to English. In German it is "Aufsteigend" and "Absteigend" which translates to "Ascending" and "Descending"

{ key: '-date', value: 'Price Date', icon: 'mdi-calendar' },
{ key: '-created', value: 'Addition date', icon: 'mdi-clock-outline' },
],
// https://wiki.openstreetmap.org/wiki/Key:place
// https://wiki.openstreetmap.org/wiki/Key:highway
Expand Down
Loading