fix: NPE crash on SearchByCodeFragment (#4652)

* Fix crash "at openfoodfacts.github.scrachx.openfood.features.searchbycode.SearchByCodeFragment.getBinding(SearchByCodeFragment.kt:30)" * Better fix for the crash (thanks VaiTon)
openfoodfacts · Apr 9, 2022 · 53f79aa · 53f79aa
1 parent c7438bb
commit 53f79aa
Show file tree

Hide file tree

Showing 2 changed files with 7 additions and 2 deletions.
diff --git a/.../java/openfoodfacts/github/scrachx/openfood/features/searchbycode/SearchByCodeFragment.kt b/.../java/openfoodfacts/github/scrachx/openfood/features/searchbycode/SearchByCodeFragment.kt
@@ -37,6 +37,7 @@ class SearchByCodeFragment : NavigationWithDrawerBaseFragment() {
     }
 
     override fun onDestroyView() {
+        removeDrawerListener()
         super.onDestroyView()
         _binding = null
     }
@@ -107,6 +108,7 @@ class SearchByCodeFragment : NavigationWithDrawerBaseFragment() {
             binding.editTextBarcode.requestFocus()
             requireActivity().showKeyboard()
         }
+
     }
 
     companion object {

diff --git a/...openfoodfacts/github/scrachx/openfood/features/shared/NavigationWithDrawerBaseFragment.kt b/...openfoodfacts/github/scrachx/openfood/features/shared/NavigationWithDrawerBaseFragment.kt
@@ -17,11 +17,14 @@ abstract class NavigationWithDrawerBaseFragment : NavigationBaseFragment(), OnNa
     }
 
     override fun onDetach() {
+        removeDrawerListener()
+        super.onDetach()
+    }
+
+    fun removeDrawerListener() {
         if (requireContext() is NavigationDrawerHost) {
             (context as NavigationDrawerHost).removeOnDrawerStatusChangedListener(this)
         }
-
-        super.onDetach()
     }
 
     override fun onDrawerOpened() {