Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

I should not have to wait for the product to upload (esp. when I have no or little network) #2677

Closed
teolemon opened this issue May 28, 2019 · 4 comments
Closed

I should not have to wait for the product to upload (esp. when I have no or little network) #2677

teolemon opened this issue May 28, 2019 · 4 comments
Labels
bug Produces incorrect or unexpected result or behaviour. editing Issues relating to allowing the user to edit products offline Offline mode product addition screenshot-available

Comments

@teolemon
Copy link
Member

image
@teolemon
Copy link
Member Author

It should save the product immediately, attempt to upload it in the background, and notify me if there are any conflicts to solve

@vanshikaarora
Copy link
Contributor

@teolemon in this issue shouldn't we detect if there is no network and display a dialog "no network detected. Try re-connecting your network" ?

@teolemon teolemon added the offline Offline mode label Nov 23, 2019
@teolemon
Copy link
Member Author

No. It's annoying. We should save to the local database, display a success in the UI, and then try to upload.

@teolemon teolemon changed the title I should not have to wait for product upload when I have no network I should not have to wait for the product to upload (esp. when I have no or little network) Nov 23, 2019
@teolemon teolemon added editing Issues relating to allowing the user to edit products product addition screenshot-available bug Produces incorrect or unexpected result or behaviour. labels Dec 26, 2019
@teolemon
Copy link
Member Author

will be fixed by @philippeauriach in #3072

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
bug Produces incorrect or unexpected result or behaviour. editing Issues relating to allowing the user to edit products offline Offline mode product addition screenshot-available
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@teolemon @vanshikaarora