The app doesn't detect it is online with Wi-Fi only connexion

[CharlesNepote]

Describe the bug

• Samsung Galaxy A5 (2016)
• Android 7.0
• No SIM card in the phone but wifi activated and internet connection ok

I'm online (see video where I open firefox and open a link in Wikipedia), and then, when scanning a product with Open Food Facts beta 3.4.3, it tells the phone is offline.

Video
https://drive.google.com/file/d/11nOI72uwagYGm5Bc1cFCD6rcXuKyXTwl/view?usp=sharing

[teolemon]

This is related to the revamp of offline product addition by @philippeauriach (we went from 2 modes to one mode) and possibly a revamp by @VaiTon .
The relevant function is below, but we shouldn't fail on that. It might be related to a bad network. Is it reproducible many times ?
https://github.com/openfoodfacts/openfoodfacts-androidapp/blob/develop/app/src/main/java/openfoodfacts/github/scrachx/openfood/utils/Utils.java#L523

[CharlesNepote]

Is it reproducible many times ?

Yes, every time. I can't get any product. The product do exists in the database.

[teolemon]

Ok, eventually this will be fixed even better by the offline mode (so that we don't accidentally add products that are already present, because of offline mode).
Meanwhile, you tell me you have a good and stable connexion, so it might either be:

• Samsung specific network behavior
• Android 7 specific network behavious
• a programming mistake on our side when only wifi is available and no sim is available (as opposed to bad network, or mobile data disabled…)

[teolemon]

After investigation, the bug appears limited in scope.
I can't reproduce on a SIM-less Pixel 1 on Android 10.
Newer devices with mobile data disabled don't have the problem either.

[teolemon]

Reported by another user

[teolemon]

Merci pour votre réponse.J'utilise ma tablette, je l'ai essayé avec wifi et 4G, mon réseau est n'était pas faible et je suis sur Android 7.

Translation:

Thank you for your reply, I am using my tablet, I tried it with wifi and 4G, my network was not weak and I am on Android 7.

[teolemon]

https://developer.android.com/about/versions/nougat/android-7.0

[teolemon]

A change in network connectivity has occurred. A default connection has either been established or lost. The NetworkInfo for the affected network is sent as an extra; it should be consulted to see what kind of connectivity event occurred.
Apps targeting Android 7.0 (API level 24) and higher do not receive this broadcast if they declare the broadcast receiver in their manifest. Apps will still receive broadcasts if they register their BroadcastReceiver with Context.registerReceiver() and that context is still valid.

12:22
that’s the best idea i have found so far
12:22
https://developer.android.com/reference/android/net/ConnectivityManager#CONNECTIVITY_ACTION

[teolemon]

Another report:

Bis vor kurzem hat die App gut funktioniert. Jetzt sagt sie immer ich wäre offline und ich bekomme keine Produkte mehr geladen.

Translation:

Until recently, the app worked fine. Now she always says I'm offline and I can't get any more products loaded.

[teolemon]

09-10 16:42:12.402 21594 21638 D OkHttp  : <-- HTTP FAILED: javax.net.ssl.SSLHandshakeException: Handshake failed

[teolemon]

09-10 16:42:12.296 21594 21638 D OkHttp  : --> GET https://ssl-api.openfoodfacts.org/api/v0/product/3270722500141.json?fields=origins%2Crecycling_instructions_to_discard%2Cother_information%2Clink%2Clast_modified_by%2Ccode%2Cquantity%2Cpackaging%2Cingredients_that_may_be_from_palm_oil_tags%2Cproduct_name_en%2Cimage_nutrition_url%2Cproduct_name_fr%2Cno_nutrition_data%2Cimage_small_url%2Cgeneric_name_en%2Ctraces%2Cvitamins_tags%2Cingredients_text_en%2Ccreator%2Cadditives_tags%2Cstates_tags%2Cwarning_fr%2Cnutrition_data_per%2Cmanufacturing_places%2Cingredients_analysis_tags%2Cpurchase_places%2Cingredients%2Crecycling_instructions_to_recycle%2Cother%2Cother_nutritional_substances_tags%2Cproduct_name%2Cingredients_text%2Cimage_nutrition_url_en%2Cwarning_en%2Cnutrition_grades_tags%2Cgeneric_name%2Ccustomer_service%2Cingredients_from_palm_oil_tags%2Crecycling_instructions_to_recycle_en%2Cimage_front_url_en%2Ccities_tags%2Cingredients_from_or_that_may_be_from_palm_oil_n%2Camino_acids_tags%2Ccustomer_service_fr%2Cnutriments%2Curl%2Cselected_images%2Ceditors_tags%2Callergens_hierarchy%2Cminerals_tags%2Cbrands_tags%2Clast_modified_t%2Crecycling_instructions_to_recycle_fr%2Cimage_front_url%2Clabels_hierarchy%2Ccountries%2Cemb_codes_tags%2Cimage_nutrition_url_fr%2Cconservation_conditions_en%2Clang%2Cimage_front_url_fr%2Cwarning%2Callergens_tags%2Cingredients_text_fr%2Cimage_ingredients_url_fr%2Ccustomer_service_en%2Crecycling_instructions_to_discard_en%2Cstores%2Callergens%2Clanguages_codes%2Cnova_groups%2Cimage_ingredients_url_en%2Cenvironment_impact_level_tags%2Cnutrient_levels%2Cbrands%2Cimage_url%2Crecycling_instructions_to_discard_fr%2Cother_information_fr%2Cgeneric_name_fr%2Ccreated_t%2Cenvironment_infocard%2Cconservation_conditions%2Cnutrition_grade_fr%2Cserving_size%2Ctraces_tags%2Cconservation_conditions_fr%2Cingredients_from_palm_oil_n%2Cother_information_en%2Ccountries_tags%2Cimage_ingredients_url%2Ccategories_tags%2Clabels_tags
09-10 16:42:12.300  2324  2787 D EnterpriseController: netId is 0
09-10 16:42:12.300  2324  2787 D Netd    : getNetworkForDns: using netid 502 for uid 10171
09-10 16:42:12.300  2324  2787 D DnsProxyListener: DNSDBG::dns addrinfo af 0
09-10 16:42:12.335 21594 21707 D h       : Found barcode in 58 ms
09-10 16:42:12.342  2311  2311 I ShotCommon: enablePreviewMsgBy : msg(In:0x2, Out:0x2)
09-10 16:42:12.342  2311  2311 I ShotCommon: enableMsgType : msg(In:0x10, Out:0xc1d)
09-10 16:42:12.361  2311 21729 I ShotCommon: disablePreviewMsgBy : msg(In:0x2, Out:0x0)
09-10 16:42:12.361  2311 21729 I ShotCommon: previewCallbackEnabled (0x0)
09-10 16:42:12.361  2311 21729 I ShotCommon: disableMsgType : msg(In:0x10, Out:0xc0d)
09-10 16:42:12.384  2311  3439 I ExynosCamera: [CAM_ID(0)][]-INFO(getParameters[1284])
09-10 16:42:12.384  2311  3439 I ExynosCamera1Parameters: [CAM_ID(0)][ParametersBack]-INFO(getParameters[243])
09-10 16:42:12.384  2311  3439 D ExynosCameraInterface: DEBUG:duration time(    0 msec):(HAL_camera_device_get_parameters)
09-10 16:42:12.384  2311  3439 D ExynosCameraInterface: DEBUG:duration time(    0 msec):(HAL_camera_device_put_parameters)
09-10 16:42:12.402 21594 21638 D OkHttp  : <-- HTTP FAILED: javax.net.ssl.SSLHandshakeException: Handshake failed

[teolemon]

We reverted a Nougat-specific fix while refactoring:
** Bug fixing **

• Fix for TLS issue on Nougat (tbm)
  we fixed an issue a while ago
  9027fd2
  84ee601#diff-eb0f032ffa66c7d8116ca7b90149a9f9

[teolemon]

The fix might be as simple as adding back this:

        if (Build.VERSION.SDK_INT == 24) {
            ConnectionSpec spec = new ConnectionSpec.Builder(ConnectionSpec.MODERN_TLS)
                    .tlsVersions(TlsVersion.TLS_1_2)
                    .cipherSuites(CipherSuite.TLS_DHE_RSA_WITH_AES_128_GCM_SHA256)
                    .build();

            httpClient = new OkHttpClient.Builder()
                    .connectTimeout(5000, TimeUnit.MILLISECONDS)
                    .readTimeout(30000, TimeUnit.MILLISECONDS)
                    .writeTimeout(30000, TimeUnit.MILLISECONDS)
                    .connectionSpecs(Collections.singletonList(spec))
                    .build();
        } else {
            httpClient = new OkHttpClient.Builder()
                    .connectTimeout(5000, TimeUnit.MILLISECONDS)
                    .readTimeout(30000, TimeUnit.MILLISECONDS)
                    .writeTimeout(30000, TimeUnit.MILLISECONDS)
                    .build();
        }

[teolemon]

#793

[teolemon]

A server side fix seems possible @stephanegigandet
https://stackoverflow.com/questions/39133437/sslhandshakeexception-handshake-failed-on-android-n-7-0

[teolemon]

otherwise, we can fix it client side

[stephanegigandet]

Making SSL changes for all users of all clients on the server side to fix one bug for one client is not a good idea IHMO. For all we know (or all we will never know), that change might break things for other clients, now or 3 years from now. So it would be much better to fix the app.

[teolemon]

A bug on 20K clients

[huzaifaiftikhar]

Closed via #3544