Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

The flash button toggle doesn't work when the Edittext is visible #4534

Closed
g123k opened this issue Mar 14, 2022 · 3 comments
Closed

The flash button toggle doesn't work when the Edittext is visible #4534

g123k opened this issue Mar 14, 2022 · 3 comments
Labels
scanning

Comments

@g123k
Copy link
Contributor

g123k commented Mar 14, 2022

What

In the barcode scanner, if the text input dialog is visible, the flash button is clickable but doesn't do anything

Steps to reproduce the behavior

  1. Open the barcode scanner
  2. Enter in "text mode"
  3. Click on the flash toggle

Expected behavior

Two options here: hide the button or make it work 😋
@g123k
Copy link
Contributor Author

g123k commented Mar 14, 2022

I can work on a fix for this issue if you want.

But what would be the right way to fix it? Hide the button or make it work?
Cc @teolemon or @Vaito

@VaiTon
Copy link
Member

VaiTon commented Mar 17, 2022

I would prefer if it was hidden while in "input barcode mode", as the user is now focusing on another part of the UI. Any opinion @teolemon ?

@g123k g123k mentioned this issue Mar 19, 2022
Merged
@g123k
Copy link
Contributor Author

g123k commented Mar 19, 2022

Thanks for your reviews @teolemon & @VaiTon
It's now fixed

@g123k g123k closed this as completed Mar 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
scanning
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@g123k @teolemon @VaiTon