Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Flash toggle should not be displayed when the quick view is visible #4538

Merged
merged 1 commit into from Mar 19, 2022

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Mar 19, 2022

Fix for issue #4534

I have also added that if the quick view is visible, the back button should close it

…e flash toggle should be displayed as the barcode detector is disabled

Also when the back button will be pressed, the bottom sheet will be closed if visible
@g123k g123k requested a review from a team as a code owner March 19, 2022 11:39
@g123k g123k changed the title [fix] Flash toggle should not be displayed when the quick view is visible fix: Flash toggle should not be displayed when the quick view is visible Mar 19, 2022
@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

Copy link
Member

@VaiTon VaiTon left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! ✅

While reviewing I was thinking about creating an interface for the scanner so that we can reduce the amount of if (useMlScanner) .... and instead call a method that is overridden in the different classes.

@teolemon
Copy link
Member

merging and releasing @VaiTon @g123k
I created #4542 based on @VaiTon 's comment

@teolemon teolemon merged commit 1fb0bb3 into openfoodfacts:develop Mar 19, 2022
g123k added a commit to g123k/openfoodfacts-androidapp that referenced this pull request Mar 19, 2022
…e flash toggle should be displayed as the barcode detector is disabled (openfoodfacts#4538)

Also when the back button will be pressed, the bottom sheet will be closed if visible
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants