Fixes #2205: Bind new field in HTML card in the Environnment tab #2208
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
https://barcode.tec-it.com/en/EAN13?data=3222471975336 |
|
@teolemon The requested changes have been made. See attached, |
|
This looks good to me. |
|
@PrajwalM2212 can you review code side ? |
|
I will review within a couple of hours. @teolemon |
PrajwalM2212
reviewed
Feb 8, 2019
app/src/main/java/openfoodfacts/github/scrachx/openfood/views/product/ProductActivity.java
Show resolved
Hide resolved
PrajwalM2212
reviewed
Feb 8, 2019
app/src/main/java/openfoodfacts/github/scrachx/openfood/views/product/ProductActivity.java
Outdated
Show resolved
Hide resolved
PrajwalM2212
reviewed
Feb 8, 2019
app/src/main/java/openfoodfacts/github/scrachx/openfood/views/product/ProductFragment.java
Outdated
Show resolved
Hide resolved
# Conflicts: # app/src/main/java/openfoodfacts/github/scrachx/openfood/models/Product.java # app/src/main/java/openfoodfacts/github/scrachx/openfood/network/OpenFoodAPIService.java All conflicts have been resolved.
…dfacts-androidapp into issue_2205 # Conflicts: # app/src/main/java/openfoodfacts/github/scrachx/openfood/models/Product.java All conflicts have been resolved.
|
All requested changes have been made. |
PrajwalM2212
approved these changes
Feb 9, 2019
|
Thanks @subhanjansaha 👍 🌱 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The new
environment_infocardfield was added and the HTML extracted was parsed and shown as a TextView in a card in the Environment tab.Related issues and discussion
#fixes #2205
Screen-shots, if any
See attached
