[4124] Fix uninitialized property exception in AllergensAlertFrament #4130
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
naivekook
force-pushed
the
vt/fix-uninitialized-property-for-allergen-alert
branch
from
cf207eb
to
1b8a651
Compare
VaiTon
requested changes
Aug 6, 2021
...java/openfoodfacts/github/scrachx/openfood/features/allergensalert/AllergensAlertFragment.kt
Outdated
Show resolved
Hide resolved
naivekook
force-pushed
the
vt/fix-uninitialized-property-for-allergen-alert
branch
from
1b8a651
to
2ce8125
Compare
|
Kudos, SonarCloud Quality Gate passed!
|
VaiTon
approved these changes
Aug 8, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Fix the uninitialized property exception in AllergensAlertFrament.
This is more like hotfix - just check the property before calling its method. The idea case to understand why
destroyhappens before recycler initialization and refactor the code, but it requires time.Related issues
#4124