Use proper named arguments to load a product #4480
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Kudos, SonarCloud Quality Gate passed!
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The issue is reproducible when deep-linking from the website to open a product with a barcode.
Open the website, type a barcode like
20518868, pick 'Open Food Facts' to open the product, the crash happens.The fix was quite simple, as the userAgent was sent in the position of the
fieldsquery param instead of being userAgent, so the product fields weren't being retrieved correctly and the request ended becominghttps://ssl-api.openfoodfacts.org/api/v0/product/20518868?fields=Scan. So I used named arguments to make sure that arguments positioning were correct.Related issues
Fixes #4222