New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Improvements for Search by text/code screen #4541

Merged

teolemon merged 1 commit into openfoodfacts:develop from g123k:search_by_code_improvements

Mar 19, 2022

Contributor

g123k commented Mar 19, 2022 •

edited by teolemon

If the view is too small, it's now possible to scroll (useful when the keyboard is visible)
The keyboard now shows the "search" icon
Validating with the keyboard (search icon or Enter button) will trigger the search
A request focus is asked, but not fully working as the MainActivity calls hideKeyboard after the Fragment lifecycle
Linked to UX problems on the search by text screen #4540


          Search by code screen:

9ca33bf

- If the view is too small, it's not possible to scroll (useful when the keyboard is visible)
- The keyboard now shows the "search" icon
- Validating with the keyboard (search icon or Enter button) will trigger the search
- A request focus is asked, but not fully working as the MainActivity calls hideKeyboard after the Fragment lifecycle

g123k requested a review from a team as a code owner

March 19, 2022 13:09

sonarcloud bot commented Mar 19, 2022

Kudos, SonarCloud Quality Gate passed!

0 Bugs
0 Vulnerabilities
0 Security Hotspots
3 Code Smells

No Coverage information
0.0% Duplication

teolemon linked an issue

that may be closed by this pull request

UX problems on the search by text screen #4540

Closed

3 tasks

teolemon added search search by barcode labels

teolemon requested review from naivekook and VaiTon

March 19, 2022 13:25

VaiTon approved these changes

View reviewed changes

Member

VaiTon commented Mar 19, 2022

Looks good to me! ✅

VaiTon mentioned this pull request

UX problems on the search by text screen #4540

Closed

3 tasks

VaiTon removed a link to an issue

UX problems on the search by text screen #4540

Closed

3 tasks

Member

teolemon commented Mar 19, 2022

merging @g123k 👍

teolemon merged commit 7459e1a into openfoodfacts:develop

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment