Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: When syncing the history, deleted products/products not found should be skipped #4554

Merged

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Mar 19, 2022

If a product is not found when syncing an old history, this product should simply be skipped

Linked to issue #4340

@g123k g123k requested a review from a team as a code owner March 19, 2022 18:32
@sonarcloud
Copy link

sonarcloud bot commented Mar 19, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon requested a review from VaiTon March 19, 2022 18:51
@teolemon teolemon added the history The use and exporting of history within the application label Mar 19, 2022
@teolemon teolemon merged commit c6a2d9e into openfoodfacts:develop Mar 21, 2022
@g123k g123k linked an issue Mar 22, 2022 that may be closed by this pull request
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
history The use and exporting of history within the application
Projects
None yet
Development

Successfully merging this pull request may close these issues.

IOException: Could not sync history. Error with product 23125124
2 participants