Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: Add background on tagline in home page #4567

Merged
merged 1 commit into from Mar 21, 2022
Merged

fix: Add background on tagline in home page #4567

merged 1 commit into from Mar 21, 2022

Conversation

Gbossard
Copy link
Contributor

Issue #4543

@Gbossard Gbossard requested a review from a team as a code owner March 21, 2022 10:31
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon teolemon linked an issue Mar 21, 2022 that may be closed by this pull request
[UI] Home screen: No hint that the tagline is clickable #4543
Closed
@teolemon teolemon added home Ideas and changes proposed for the application home tagline labels Mar 21, 2022
g123k
g123k approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@teolemon
Copy link
Member

Thank you @Gbossard for your contribution to Open Food Facts, and congratulations on your 1st merged PR 🎉 :-)

@teolemon teolemon merged commit cd2e2b5 into openfoodfacts:develop Mar 21, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g123k g123k g123k approved these changes

Assignees
No one assigned
Labels
home Ideas and changes proposed for the application home tagline
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Home screen: No hint that the tagline is clickable
3 participants
@Gbossard @teolemon @g123k