Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: overlapping icon in LoginActivity #4568

Merged
merged 1 commit into from Mar 24, 2022
Merged

fix: overlapping icon in LoginActivity #4568

merged 1 commit into from Mar 24, 2022

Conversation

FlorentRousselle
Copy link
Contributor

fix : issue #4545

  • changed id in LoginActivity.kt
  • id added in activity_login.xml for textInputLayout

@FlorentRousselle FlorentRousselle requested a review from a team as a code owner March 21, 2022 10:33
g123k
g123k approved these changes Mar 21, 2022
View reviewed changes
Copy link
Contributor

@g123k g123k left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(The error is now displayed in the layout instead of the EditText like before)

LGTM!

@teolemon teolemon added the login Issues relating to allowing the user to log into their OFF accounts label Mar 21, 2022
@teolemon teolemon linked an issue Mar 21, 2022 that may be closed by this pull request
[UI] Login: overlapping icons in the password field #4545
Closed
@teolemon
Copy link
Member

Small merge conflicts @FlorentRousselle @g123k

@FlorentRousselle
error stop overlapping
54845e8 
* changed id in LoginActivity.kt
* id added in activity_login.xml for textInputLayout
@sonarcloud
Copy link

sonarcloud bot commented Mar 24, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@FlorentRousselle
Copy link
Contributor Author

fix : issue #4545
fix: merge conflicts for overlapping icon

Screenshot_20220324-095509

@teolemon
Copy link
Member

Thank you @FlorentRousselle 👍 for the fix.
Merging.

@teolemon teolemon merged commit 6cb1e4f into openfoodfacts:develop Mar 24, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@g123k g123k g123k approved these changes

Assignees
No one assigned
Labels
login Issues relating to allowing the user to log into their OFF accounts
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[UI] Login: overlapping icons in the password field
3 participants
@FlorentRousselle @teolemon @g123k