Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: SearchView : ensure that the bottom navigation bar is hidden when the keyboard is visible and vice-versa #4574

Merged
merged 1 commit into from Mar 21, 2022

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Mar 21, 2022

A fix for #4558

This should fix all issues we have with the keyboard and the SearchView in the MainActivity
For your knowledge: setOnActionExpandListener is never called

…is on the SearchView, the bottom navigation is hidden
@g123k g123k requested a review from a team as a code owner March 21, 2022 14:40
@sonarcloud
Copy link

sonarcloud bot commented Mar 21, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon
Copy link
Member

thanks @g123k 🌮

@teolemon teolemon merged commit f61f5ac into openfoodfacts:develop Mar 21, 2022
@g123k g123k mentioned this pull request Mar 22, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants