fix: Nutrition edition: no listener was set on unit/"data per" #4579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… causing the app to always send per 100g
g123k
changed the title
|
Kudos, SonarCloud Quality Gate passed!
|
g123k
changed the title
|
I'm going to merge and deploy it to internal so that we can thoroughly test. |
|
|
I have noticed this behavior yesterday, but wasn't sure if it was a bug or not. |
|
We should hide it, but reshow it when we untick the toggle, and ensure the boolean is sent each time. |
|
Ok I will fix that |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I think I've found why the "nutrition_data_per" was always wrong: no listener was set on the radio group.
This should resolve #4470
(But please test it, as I'm not 100% sure)