Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: "Compile Screenshot Tests" not passing #4584

Merged
merged 1 commit into from Mar 22, 2022
Merged

fix: "Compile Screenshot Tests" not passing #4584

merged 1 commit into from Mar 22, 2022

Conversation

g123k
Copy link
Contributor

@g123k g123k commented Mar 22, 2022

On my previous PRs, all "Compile Screenshot Tests" failed.
This should resolve the problem

@g123k g123k requested a review from a team as a code owner March 22, 2022 10:31
@sonarcloud
Copy link

sonarcloud bot commented Mar 22, 2022

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@teolemon
Copy link
Member

Great, a green build is less cognitive load 👍

@teolemon teolemon merged commit b8d5adb into openfoodfacts:develop Mar 22, 2022
@g123k g123k mentioned this pull request Mar 22, 2022
Closed
12 tasks
@g123k g123k linked an issue Mar 22, 2022 that may be closed by this pull request
Screenshots tests are failing #4497
Closed
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@teolemon teolemon teolemon approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Screenshots tests are failing
2 participants
@g123k @teolemon