feat: #382 - added a "packaging" tag type #383
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Impacted files: * `api_get_autocompleted_suggestions_test.dart`: added a test about packaging * `TagType.dart`: added a "packaging" tag type
1 task
M123-dev
approved these changes
Feb 11, 2022
Comment on lines
+202
to
+205
| input: 'briq', | ||
| ); | ||
|
|
||
| _listContains(result, 'briq'); |
There was a problem hiding this comment.
We expect that it autocompletes the the same as the input, not very challenging but this is obviously more a task for the backend
There was a problem hiding this comment.
Not sure what you mean but just in case, in French packaging suggestions from briq are ['Brique','Briquette'].
|
Thank you @M123-dev for your code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Impacted files:
api_get_autocompleted_suggestions_test.dart: added a test about packagingTagType.dart: added a "packaging" tag typeWhat
getAutocompletedSuggestionscan be called for packaging.