Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ensure we support packaging_shapes and packaging_materials taxonomies #605

Closed
Tracked by #3309
, #3310
...
teolemon opened this issue Nov 6, 2022 · 0 comments · Fixed by #610
Closed
Tracked by #3309
, #3310
...

Ensure we support packaging_shapes and packaging_materials taxonomies #605

teolemon opened this issue Nov 6, 2022 · 0 comments · Fixed by #610
Assignees
@monsieurtanuki
Labels
📦 Packaging

Comments

@teolemon
Copy link
Member

teolemon commented Nov 6, 2022

What
@monsieurtanuki monsieurtanuki self-assigned this Nov 6, 2022
monsieurtanuki added a commit to monsieurtanuki/openfoodfacts-dart that referenced this issue Nov 7, 2022
@monsieurtanuki
feat: openfoodfacts#605 - taxonomy - support of packaging materials a…
6e6f604 
…nd shapes

New files:
* `api_getTaxonomyPackagingMaterialsServer_test.dart`: server tests around Packaging Material Taxonomy
* `api_getTaxonomyPackagingShapesServer_test.dart`: server tests around Packaging Shape Taxonomy
* `TaxonomyPackagingMaterial.dart`: Packaging Material Taxonomy classes
* `TaxonomyPackagingMaterial.g.dart`: generated
* `TaxonomyPackagingShape.dart`: Packaging Shape Taxonomy classes
* `TaxonomyPackagingShape.g.dart`: generated

Impacted files:
* `api_get_autocompleted_suggestions_test.dart`: added suggestion tests for packaging materials and shapes
* `openfoodfacts.dart`: added methods `getTaxonomyPackagingMaterials` and `getTaxonomyPackagingShapes`
* `TagType.dart`: added field types for packaging materials and shapes
@monsieurtanuki monsieurtanuki mentioned this issue Nov 7, 2022
Merged
monsieurtanuki added a commit that referenced this issue Nov 7, 2022
@monsieurtanuki
feat: #605 - taxonomy - support of packaging materials and shapes (#610)
43f83a9 
New files:
* `api_getTaxonomyPackagingMaterialsServer_test.dart`: server tests around Packaging Material Taxonomy
* `api_getTaxonomyPackagingShapesServer_test.dart`: server tests around Packaging Shape Taxonomy
* `TaxonomyPackagingMaterial.dart`: Packaging Material Taxonomy classes
* `TaxonomyPackagingMaterial.g.dart`: generated
* `TaxonomyPackagingShape.dart`: Packaging Shape Taxonomy classes
* `TaxonomyPackagingShape.g.dart`: generated

Impacted files:
* `api_get_autocompleted_suggestions_test.dart`: added suggestion tests for packaging materials and shapes
* `openfoodfacts.dart`: added methods `getTaxonomyPackagingMaterials` and `getTaxonomyPackagingShapes`
* `TagType.dart`: added field types for packaging materials and shapes
@github-actions github-actions bot mentioned this issue Nov 7, 2022
Merged
This was referenced Nov 10, 2022
Open
Open
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@monsieurtanuki monsieurtanuki

Labels
📦 Packaging
Projects
📦 Packaging improvements
Archived in project
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat: #605 - taxonomy - support of packaging materials and shapes monsieurtanuki/openfoodfacts-dart
2 participants
@teolemon @monsieurtanuki