fix_5/#90 - added comments to Parameter-related classes #177
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
On the way to a 130/130 pub.dev score... Impacted files: * `ContainsAdditives.dart`: added a comment on class; refactored as non-nullable * `OutputFormat.dart`: added a comment on class and enum; refactored * `Page.dart`: added a comment on class; refactored as non-nullable * `PageSize.dart`: added a comment on class; refactored as non-nullable * `Parameter.dart`: added a comment on class; created method `addToMap` * `ProductSearchQueryConfiguration.dart`: added a comment on class; refactored some fields as non-nullable * `SearchSimple.dart`: not done much as the purpose of the class is unclear * `SearchTerms.dart`: added a comment on class; refactored as non-nullable * `SortBy.dart`: added a comment on class and enum; refactored * `TagFilter.dart`: added a comment on class and enum; overridden new method `addToMap`; refactored
I've just rolled back changes I made that actually added complexity without added value. Impacted files: * `Parameter.dart` * `ProductSearchQueryConfiguration.dart` * `TagFilter.dart`
peterwvj
approved these changes
Jul 12, 2021
|
Thank you @peterwvj for your code review! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On the way to a 130/130 pub.dev score...
By the way @teolemon @stephanegigandet: what's the purpose of
search_type=1orsearch_type=0in the search API URI?Impacted files:
ContainsAdditives.dart: added a comment on class; refactored as non-nullableOutputFormat.dart: added a comment on class and enum; refactoredPage.dart: added a comment on class; refactored as non-nullablePageSize.dart: added a comment on class; refactored as non-nullableParameter.dart: added a comment on class; created methodaddToMapProductSearchQueryConfiguration.dart: added a comment on class; refactored some fields as non-nullableSearchSimple.dart: not done much as the purpose of the class is unclearSearchTerms.dart: added a comment on class; refactored as non-nullableSortBy.dart: added a comment on class and enum; refactoredTagFilter.dart: added a comment on class and enum; overridden new methodaddToMap; refactored