Setting default language to OpenFoodFactsLanguage.WORLD and fields to… #75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… ProductField.ALL if user does not provide them Adding tests to cover changes. Updating tests.
stephanegigandet
approved these changes
Jan 30, 2021
stephanegigandet
requested changes
Feb 4, 2021
|
@stephanegigandet , my bad. I will fix this and set it to EN. |
|
@stephanegigandet I have rebased my branch on the latest changes on the master. And with your changes on #76, no need anymore to set a default value for the language. I am only setting the field to ALL in case this was not provided on the configuration. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setting default language to OpenFoodFactsLanguage.WORLD and fields to ProductField.ALL if user does not provide them.
Adding tests to cover changes.
Updating tests.