This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
[Proposal] New labels experience (from links to images) #707
Comments
|
We should probably do a mockup with one label in a branch, and make it generic when we stabilize an API |
6 tasks
|
See the module TagListView. |
7 tasks
7 tasks
|
I'm adding the latest mockup @jncosideout |
|
Thanks. I will work toward that as close as I can. Will you please tell me the difference between the two since they look almost identical to me. |
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Oct 26, 2020
Allow the 'descriptionShort' text to be fully displayed in the AttributeView. Make the AttributeBLTNpageItem look more like the mock-up, and add the entire AttributeView to the BLTNpageItem. Resolves: openfoodfacts#707
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Nov 1, 2020
The product summary Overview needs to display rows for a product's Attributes, whose data are fetched from the newly integrated ProductAttribute API endpoint. This required a subclass of UIView and a new class of TableView Cells to hold them. When the user taps an Attribute row, a pop-up info card will be displayed showing a longer description. Swiping left will show more related information on the pop-up info card. Resolves: openfoodfacts#707
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Nov 8, 2020
The product summary Overview needs to display rows for a product's Attributes, whose data are fetched from the newly integrated ProductAttribute API endpoint. This required a subclass of UIView and a new class of TableView Cells to hold them. When the user taps an Attribute row, a pop-up info card will be displayed showing a longer description. Swiping left will show more related information on the pop-up info card. Resolves: openfoodfacts#707
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Nov 8, 2020
Created delegate protocol for AttributeTableViewCell to call back to ProductDetailViewController so it can launch the FloatingPanelVC Extend ProductDetailVC so it can handle FloatingPanels similar to ScannerViewController. Create ProductAttributeViewController.swift and .storyboard to be the FloatingPanels VC and view to hold AttributeView Resolves: openfoodfacts#707
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Nov 22, 2020
The product summary Overview needs to display rows for a product's Attributes, whose data are fetched from the newly integrated ProductAttribute API endpoint. This required a subclass of UIView and a new class of TableView Cells to hold them. When the user taps an Attribute row, a pop-up info card will be displayed showing a longer description. Swiping left will show more related information on the pop-up info card. Resolves: openfoodfacts#707
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Nov 22, 2020
Created delegate protocol for AttributeTableViewCell to call back to ProductDetailViewController so it can launch the FloatingPanelVC Extend ProductDetailVC so it can handle FloatingPanels similar to ScannerViewController. Create ProductAttributeViewController.swift and .storyboard to be the FloatingPanels VC and view to hold AttributeView Resolves: openfoodfacts#707
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Nov 25, 2020
Add the frame of the image to the exclusion path of the text view. Create func getIconAspectConstraint() to get the dynamic aspect ratio of the image in code so we can dynamically adjust the imageView height and width. Place image related code in completion handle of KingFisher setImage(with: resource) to ensure the adjustments are attempted after the image is retrieved. Resolves: openfoodfacts#707
teolemon
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Dec 25, 2020
teolemon
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Mar 4, 2021
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
May 1, 2021
The product summary Overview needs to display rows for a product's Attributes, whose data are fetched from the newly integrated ProductAttribute API endpoint. This required a subclass of UIView and a new class of TableView Cells to hold them. When the user taps an Attribute row, a pop-up info card will be displayed showing a longer description. Swiping left will show more related information on the pop-up info card. Resolves: openfoodfacts#707
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
May 1, 2021
Created delegate protocol for AttributeTableViewCell to call back to ProductDetailViewController so it can launch the FloatingPanelVC Extend ProductDetailVC so it can handle FloatingPanels similar to ScannerViewController. Create ProductAttributeViewController.swift and .storyboard to be the FloatingPanels VC and view to hold AttributeView Resolves: openfoodfacts#707
jncosideout
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
May 1, 2021
Add the frame of the image to the exclusion path of the text view. Create func getIconAspectConstraint() to get the dynamic aspect ratio of the image in code so we can dynamically adjust the imageView height and width. Place image related code in completion handle of KingFisher setImage(with: resource) to ensure the adjustments are attempted after the image is retrieved. Resolves: openfoodfacts#707
teolemon
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Aug 1, 2021
teolemon
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Sep 1, 2021
teolemon
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Oct 9, 2021
teolemon
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Oct 9, 2021
teolemon
added a commit
to jncosideout/openfoodfacts-ios
that referenced
this issue
Oct 23, 2021
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
[Proposal] New labels experience (from links to images)
https://docs.google.com/document/d/1ADRNzOZGRS308Ve02tHbSLnaksw3_tdSyXtIB9kIGz0/edit#heading=h.rn7so1lxwbej
The text was updated successfully, but these errors were encountered: