This repository has been archived by the owner on Sep 5, 2023. It is now read-only.
WIP - fix: Replaced deprecated UIWebView #627
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s still an issue with the scrolling of the page with nutrition data: I can not scroll to the bottom. Note that this update should be made only when Apple has resolved their issue with WebKit (seen issue #618).
|
@aleene I've changed the base to |
|
@aleene What's the status of this ? Should we close or try to update ? |
|
Apple will deprecate the old solution, so we should implement it. I wanted to wait to the last moment, as there were issues with apple proposed solution. If the old solution is no longer supported, we can merge it in. |
|
Ok, let's wait. I rebased the branch for more visibility on your changes. |
|
CodeFactor found multiple issues last seen at 5d8431b: Prefer at least one space after slashes for comments. |
teolemon
changed the title
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
The UIWebView entries were replaced with UIWebKit.
Type of Changes
Proposed changes
There is still an issue with the tableView height of the Nutrition tab. I am not able yo scroll to the bottom. The cell height of the Nutrition table is OK.
There is still an issue with the UIWebKit, which needs to be solved by Apple first. So we can put this pull request on hold as long as that is not yet done.