Skip to content
This repository has been archived by the owner on Sep 5, 2023. It is now read-only.

feat: [WIP] Integrate Matomo analytics tracking #697

Closed
wants to merge 11 commits into from

Conversation

philippeauriach
Copy link
Collaborator

@philippeauriach philippeauriach commented Jul 19, 2020

PR Description

Type of Changes

  • New feature

⚠️ Nothing is operationel yet, as we don't have the Matomo server for now

Proposed changes

  • integrates anonymous Matomo analytics tracking
  • ask the user at first open if he agreed to be tracked (default to false)
  • privacy screen in setting allowing to enable / disable tracking
  • in the new priivacy screen, allow disabling crash reporting

views tracked :

  • scanner view
    products/edit
  • events tracked :
    • scanner scanned (with barcode as event name)
    • scanner result card swiped up (with barcode as event name)
  • allergen alert added (with allergen code as event name)
  • ingredient-analysis
    • enabled (with name of ingredient analysis)
    • disabled (with name of ingredient analysis)
  • user-account
    • login
    • logout
    • login prompt
      • name: robotoff
    • logged-in-after-prompt
      • name: robotoff
  • products :
    • edited (saved a product) (with barcode as event name)
    • edited-nutrition-facts (saved a product’s nutrition facts table) (with barcode as event name)
    • edited-ingredients (saved a product’s ingredients) (with barcode as event name)
    • edited-ingredients-picture (added a product’s ingredients picture) (with barcode as event name)

Screenshots

After

Simulator Screen Shot - iPhone SE (2nd generation) - 2020-07-19 at 18 12 34
Simulator Screen Shot - iPhone SE (2nd generation) - 2020-07-19 at 18 12 50

Copy link

@stephanegigandet stephanegigandet left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks great :)

@philippeauriach philippeauriach force-pushed the feature/matomo-integration branch 2 times, most recently from b87dace to 6f91a7a Compare July 31, 2020 11:17
@philippeauriach
Copy link
Collaborator Author

We still miss the matomo server url. @teolemon what's the take on this?

@teolemon
Copy link
Member

@cquest do you have some info for @philippeauriach regarding the matomo path for the app ? Any ETA ?

@teolemon teolemon added the matomo label Dec 5, 2020
@teolemon
Copy link
Member

teolemon commented Dec 5, 2020

@philippeauriach I reckon clicking that button is safe ?
image

@philippeauriach
Copy link
Collaborator Author

@philippeauriach I reckon clicking that button is safe ?

image

I like this button! Should be yes, a conflictless merge theorically works anytime.

@teolemon
Copy link
Member

Like the Cavalry, we arrive late, but we now have a Matomo install : https://analytics.openfoodfacts.org/

@teolemon
Copy link
Member

Update branch attempt failed
Merge conflict between head and base.

@teolemon
Copy link
Member

@teolemon
Copy link
Member

teolemon commented Mar 4, 2021

CodeFactor found multiple issues last seen at f844be1:

Lines should not have trailing whitespace.

Complex Method

TODOs should be resolved (config).

Prefer at least one space after slashes for comments.

@teolemon teolemon marked this pull request as ready for review July 17, 2021 10:58
@teolemon teolemon removed the request for review from raphael0202 July 17, 2021 11:01
@teolemon teolemon requested a review from a team July 17, 2021 11:01
@teolemon teolemon changed the title [WIP] Integrate Matomo analytics tracking feat: [WIP] Integrate Matomo analytics tracking Oct 9, 2021
@teolemon
Copy link
Member

teolemon commented Sep 5, 2023

Thank you @philippeauriach
Given the merge conflict, and the fact that we moved to flutter, I'm closing this PR.

@teolemon teolemon closed this Sep 5, 2023
@teolemon teolemon deleted the feature/matomo-integration branch September 5, 2023 11:20
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

4 participants