-
-
Notifications
You must be signed in to change notification settings - Fork 63
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: fixed search products by text #191
Conversation
@Fedeton thanks ! note:
|
@Fedeton a quality check is failing, can you fix it ? |
I'm sorry. Give me some time and than I try to fix it. |
9add60c
to
30f6b72
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks, that's indeed important !
Still failing @Fedeton ! |
I have made another commit, should I do something else or should I just wait? |
@Fedeton still failing :-/ (were you able to run tests them locally ?)
|
@Fedeton can you update your branch with latest commit in develop? |
Kudos, SonarCloud Quality Gate passed! 0 Bugs No Coverage information |
Hello, I have performed the following steps on my local repo:
|
@Fedeton I invited you to our python team so next time you can start your branch directly on the project :-) |
Thanks for your contribution 🎉 |
It was a pleasure, thanks to all of you for the support |
Description
The
/api/v2/search
endpoint always returns the same results no matter what text is used.Solution
Looking at the main site (https://world.openfoodfacts.org) and the openfoodfacts-dart repository I noticed that both use this endpoint
/cgi/search.pl
which should work fine with the same parameters.Related issue(s)