Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: improve sdk #193

Merged
merged 8 commits into from
Dec 4, 2023
Merged

fix: improve sdk #193

merged 8 commits into from
Dec 4, 2023

Conversation

raphael0202
Copy link
Contributor

@raphael0202 raphael0202 commented Dec 4, 2023 •
edited

see commits.

@raphael0202 raphael0202 requested a review from a team as a code owner December 4, 2023 11:16
@sonarcloud SonarCloud
Copy link

sonarcloud bot commented Dec 4, 2023

Kudos, SonarCloud Quality Gate passed!    Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 1 Code Smell

No Coverage information No Coverage information
0.0% 0.0% Duplication

alexgarel
alexgarel approved these changes Dec 4, 2023
View reviewed changes
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@alexgarel alexgarel merged commit 07f224c into develop Dec 4, 2023
8 checks passed
@alexgarel alexgarel deleted the improve-sdk branch December 4, 2023 17:40
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Dec 4, 2023
Closed
@openfoodfacts-bot openfoodfacts-bot mentioned this pull request Feb 6, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexgarel alexgarel alexgarel approved these changes

Assignees

@raphael0202 raphael0202

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@raphael0202 @alexgarel