Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: display new Nutri-Score (except on fr.openfoodfacts.org) #10163

Merged
merged 7 commits into from
May 16, 2024

Conversation

stephanegigandet
Copy link
Contributor

This PR changes the Nutri-Score attribute so that it uses the 2023 Nutri-Score, and is linked to the new Nutri-Score 2023 knowledge panel, for all users, and for all countries (including world), except fr.openfoodfacts.org

The new Nutri-Score logo with "New calculation" is shown on the attribute, but it is not very legible. Maybe we could keep it only on the knowledge panel on the product page.

image

image

@stephanegigandet stephanegigandet requested a review from a team as a code owner April 22, 2024 16:36
@github-actions github-actions bot added 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. Display Attributes https://wiki.openfoodfacts.org/Product_Attributes 🚦 Nutri-Score labels Apr 22, 2024
@github-actions github-actions bot added API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) 🧪 integration tests labels May 3, 2024
Copy link
Member

@alexgarel alexgarel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Note: see my comment.

lib/ProductOpener/KnowledgePanels.pm Outdated Show resolved Hide resolved
@github-actions github-actions bot added the 💥 Merge Conflicts 💥 Merge Conflicts label May 13, 2024
@github-actions github-actions bot removed the 💥 Merge Conflicts 💥 Merge Conflicts label May 14, 2024
Copy link

sonarcloud bot commented May 16, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@stephanegigandet stephanegigandet merged commit bb8882f into main May 16, 2024
12 checks passed
@stephanegigandet stephanegigandet deleted the display-new-nutriscore branch May 16, 2024 12:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
API Issues related to the Open Food Facts API. More specific labels exist & should be used (API WRITE…) Attributes https://wiki.openfoodfacts.org/Product_Attributes Display 🧪 integration tests 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels Nutri-Score v2 🚦 Nutri-Score Template::Toolkit The templating toolkit used by product opener. The starting point for HTML/JS/CSS fixes. 🧪 tests
Projects
Status: Done
Development

Successfully merging this pull request may close these issues.

None yet

3 participants