fix: Accessibility [2.4.1]: Provide a skip links option Fixes #6575 #10168
Conversation
github-actions
bot
added
✏️ Editing
🗺️ Maps
CSS
🏭 Producers Platform
po/common/ar.po
Outdated
| @@ -6809,3 +6809,6 @@ msgctxt "nutrient_info_proteins_benefit" | |||
| msgid "Foods that are rich in proteins are usually rich in calcium or iron which are essential minerals with numerous health benefits." | |||
| msgstr "" | |||
|
|
|||
| msgctxt "skip_to_content" | |||
| msgid "Skip to Content" | |||
| msgstr "تخطى الى المحتوى" | |||
There was a problem hiding this comment.
It's not necessary to add all translations, as we will use Crowdin to get translations. But you need at least to have the changes in en.po (as you did) and also common.pot which is the file used by Crowdin.
There was a problem hiding this comment.
Looks good, thank you @abbyrhart ! Can you just add the new string to po/common/common.pot?
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #10168 +/- ##
==========================================
+ Coverage 49.54% 49.89% +0.34%
==========================================
Files 67 71 +4
Lines 20650 21034 +384
Branches 4980 5041 +61
==========================================
+ Hits 10231 10494 +263
- Misses 9131 9245 +114
- Partials 1288 1295 +7 ☔ View full report in Codecov by Sentry. |
Yes, just did that! @stephanegigandet should I make a new PR or is there a way to add this code here? |
@abbyrhart : you can just commit your changes and do "git push" on your branch in it will update this PR. |
@stephanegigandet Done! Let me know if there is anything else you need me to do. |
|
|
Thanks @abbyrhart for this contribution 🎉 ! |
…10168) * Added skip links and language translations * removed skip to content * Fixed skip to content focus * Added skip links and language translations * fixed squash * Updated common.pot to fix skip to content translation * expected test results updated * fix fr translation --------- Co-authored-by: Stéphane Gigandet <stephane@openfoodfacts.org> Co-authored-by: Alex Garel <alex@openfoodfacts.org> Co-authored-by: Pierre Slamich <pierre@openfoodfacts.org> Co-authored-by: Antoine B <antoine.bastos@edu.univ-eiffel.fr>
What
Added skip to content links on templated main page, added "Skip to Content" translation in available languages.
Screenshot
Related issue(s) and discussion