Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Quality facet - Add a "forbidden" words quality rule #1025

Open
2 tasks
Tracked by #5809 ...
teolemon opened this issue Jan 3, 2018 · 9 comments
Open
2 tasks
Tracked by #5809 ...

Quality facet - Add a "forbidden" words quality rule #1025

teolemon opened this issue Jan 3, 2018 · 9 comments
Labels
🎯 Big Bang for Your Time Issues that promise a great return on the time invested in solving them 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🎯 P1 candidate

Comments

@teolemon
Copy link
Member

teolemon commented Jan 3, 2018

What

  • Add a "forbidden" words quality facet that will look for insults, vulgar words in ingredients, product name, brands
  • Add an edit rule that will send a notification to Slack as soon as one is added

Sources

Part of

@teolemon teolemon added the 🧽 Data quality https://wiki.openfoodfacts.org/Quality label Jan 3, 2018
@stephanegigandet stephanegigandet added the 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data label Jun 17, 2019
@teolemon teolemon added 🎯 Big Bang for Your Time Issues that promise a great return on the time invested in solving them 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits labels Jul 13, 2019
@CharlesNepote
Copy link
Member

I disagree to build a new quality facet as there will be many false positives -- e.g. 7 products use "couille" as part of their name; 1689 products use "bites" in their name; etc.

There should be another process. Example:

  • the system alerts some people that XXXX product may contains bad words (in real-time?)
  • someone controls the product
  • he makes a correction OR leave the product as-is
  • he tells the system that the alert has been processed

I think ideally:

  • it should be in real-time
  • the system should keep the information if a product is a false positive
  • it should be replayed

@teolemon
Copy link
Member Author

I prefer a quick and dirty facet with false positives to RT notifications with false positives with a feedback loop that probably won't be implemented.

@CharlesNepote
Copy link
Member

Me either! But why do you think a better solution won't be implemented? There are many developers that could do that.

And we can start with RT notifications without keeping false positive information. If our needs are clearly explained, it shouldn't be so long and difficult.

@zigouras
Copy link
Contributor

zigouras commented Nov 3, 2019

I can work on this if you guys want. I think what @teolemon proposed is a good initial plan. Start with a simple quality facet first and then we can think about adding RT Slack notifications.

@VaiTon
Copy link
Member

VaiTon commented Nov 3, 2019

@zigouras you can start working on it! I'm assigning you.

@teolemon
Copy link
Member Author

@teolemon
Copy link
Member Author

@teolemon
Copy link
Member Author

Ok, we had a much more problematic issue which stayed undetected for several months.

@teolemon teolemon changed the title Add a "forbidden" words quality rule Quality facet - Add a "forbidden" words quality rule Oct 11, 2021
@TaciteOFF
Copy link
Contributor

Found the N word tonight, and obviously not on the product itself

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🎯 Big Bang for Your Time Issues that promise a great return on the time invested in solving them 🧽 Data quality - Measure - Quality facets One of the facets available in Open Food Facts is /quality & allows us to spot products w/ bad data 🧽 Data quality - Prevention - Edit rules Edit Rules prevent quality issues by selectively ignoring or altering specific edits 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🎯 P1 candidate
Projects
Status: To do
Status: To discuss and validate
Status: Done
Development

No branches or pull requests

6 participants