Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Disable NOVA + Nutri-Score on OFF if category = Non food products #1577

Open
1 task
Tracked by #5519
teolemon opened this issue Dec 15, 2018 · 11 comments
Open
1 task
Tracked by #5519

Disable NOVA + Nutri-Score on OFF if category = Non food products #1577

teolemon opened this issue Dec 15, 2018 · 11 comments
Labels
non-food products Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova

Comments

@teolemon
Copy link
Member

teolemon commented Dec 15, 2018

What

  • Disable NOVA + Nutri-Score on Open Food Facts if category = en:Non food products
@teolemon teolemon added the Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova label May 13, 2019
@VaiTon
Copy link
Member

VaiTon commented May 25, 2019

I think this has been done. @teolemon @stephanegigandet

@hangy hangy added the Fixed ? This issue might have been fixed. We can close them once we verify that they have. label May 25, 2019
@CharlesNepote CharlesNepote removed the Fixed ? This issue might have been fixed. We can close them once we verify that they have. label May 27, 2019
@CharlesNepote
Copy link
Member

@vanshikaarora
Copy link
Contributor

Hey @teolemon @VaiTon if no one is working on this issue. Can I please take this up?

@stephanegigandet
Copy link
Contributor

stephanegigandet commented May 27, 2019

Hi @vanshikaarora, sure, go ahead. It has been fixed for NOVA, but not for the Nutri-Score

Nova fix is at: https://github.com/openfoodfacts/openfoodfacts-server/blob/master/lib/ProductOpener/Food.pm#L4995

Thank you!

@VaiTon
Copy link
Member

VaiTon commented May 27, 2019

Hey @vanshikaarora sure you can! All contributions are well accepted here!
I would say good luck with it! 😆

@vanshikaarora
Copy link
Contributor

Hey @VaiTon @stephanegigandet @CharlesNepote , how to check whether it is a non-food product, is there a specific category tag for non-food products?

@VaiTon
Copy link
Member

VaiTon commented May 28, 2019

@vanshikaarora
Copy link
Contributor

Yep, see https://world.openfoodfacts.org/category/non-food-products

@VaiTon in the class CategoryName the field name would return Non food products right?Or is there a different feild with the value Non food products?

@VaiTon
Copy link
Member

VaiTon commented May 28, 2019

Yep, see https://world.openfoodfacts.org/category/non-food-products

@VaiTon in the class CategoryName the field name would return Non food products right?Or is there a different feild with the value Non food products?

I think that should be right but @stephanegigandet could definitely answer correctly.

@hangy
Copy link
Member

hangy commented May 28, 2019

I believe, it should be possible to check for that category with has_tag($product_ref, 'categories', 'en:non-food-products').

@vanshikaarora
Copy link
Contributor

Hey, I have solved this Issue here openfoodfacts/openfoodfacts-androidapp#2686. Kindly review :)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
non-food products Nova - Ultra-processed foods NOVA is an indicator for food ultra-processing https://world.openfoodfacts.org/nova
Projects
Status: To Discuss & Validate
Status: To discuss and validate
Development

No branches or pull requests

6 participants