Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add tests for CSV and XML import conversion scripts #2014

Open
stephanegigandet opened this issue Jun 27, 2019 · 0 comments
Open

Add tests for CSV and XML import conversion scripts #2014

stephanegigandet opened this issue Jun 27, 2019 · 0 comments
Labels
Data import ✨ Feature Features or enhancements to Open Food Facts server

Comments

@stephanegigandet
Copy link
Contributor

Import.pm has a lot of features to read XML or CSV files of various formats provided by manufacturers to extract the values we are interested in, and to normalize them.

We need test scripts that ensure that those conversion features do not get broken by new changes.

Proposal:

  • for each of the convert_*_data.pl scripts, commit a sample input file (e.g. with 100 products) and the resulting (aka "golden") converted file.
  • have the script run on the sample input, and compare the output with the golden output.
@stephanegigandet stephanegigandet added ✨ Feature Features or enhancements to Open Food Facts server Data import labels Jun 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Data import ✨ Feature Features or enhancements to Open Food Facts server
Projects
Status: To discuss and validate
Development

No branches or pull requests

1 participant