Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Apply image rotation algorithm on the fly #2755

Open
3 tasks
teolemon opened this issue Dec 8, 2019 · 5 comments
Open
3 tasks

Apply image rotation algorithm on the fly #2755

teolemon opened this issue Dec 8, 2019 · 5 comments

Comments

@teolemon
Copy link
Member

teolemon commented Dec 8, 2019

What

  • Apply the existing image rotation algorithm on the fly
    • after all photo uploads/selections, once we get the OCR
    • not just by running update_all_products.pl script

Why

  • Apps send us badly rotated images for products.
  • This creates a lot of work for humans while we know how to do it automatically.

Code pointer

Autorotate option in

Part of

@teolemon teolemon added the 🐛 bug This is a bug, not a feature request. label Dec 8, 2019
@hangy
Copy link
Member

hangy commented Dec 8, 2019

Example: https://world.openfoodfacts.org/product/8480010022155/turron-de-yema-tostada-sin-azucares-anadidos-eroski

Autorotate option in

That option can be set from the command line:

"autorotate" => \$autorotate,

Do you mean that you want it to be performed directly after the upload? I think it's currently done if the user tries to extract the ingredients text:

$product_ref->{images}{$id}{orientation} = compute_orientation_from_cloud_vision_annotations($cloudvision_ref);

@hangy
Copy link
Member

hangy commented Dec 12, 2019

Can you please explain why this is a bug, what's the expected behaviour, and what's the actual behaviour?

@teolemon
Copy link
Member Author

done @hangy

@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server 🖼️ Image upload 🖼️ Images and removed 🐛 bug This is a bug, not a feature request. labels Jan 10, 2020
@teolemon teolemon added the P2 label Jan 27, 2020
@github-actions
Copy link
Contributor

github-actions bot commented Jul 4, 2020

Stale issue message

@raphael0202
Copy link
Contributor

We can do this easily on Robotoff side as we already store this information. Is it okay to move it to Robotoff issues?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: To discuss and validate
Development

No branches or pull requests

3 participants