Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Show packager code maps as a modal directly on the product page #3764

Closed
3 tasks
Tracked by #5508 ...
teolemon opened this issue Jun 29, 2020 · 2 comments
Closed
3 tasks
Tracked by #5508 ...

Show packager code maps as a modal directly on the product page #3764

teolemon opened this issue Jun 29, 2020 · 2 comments
Labels
✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🗺️ Maps mockup-required 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near- Product Page ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects

Comments

@teolemon
Copy link
Member

teolemon commented Jun 29, 2020

Show packager code maps as a modal on the product page.

There can be several packager codes, and thus several maps

  • Option 1: Show them all expanded, side by side
  • Option 2: show the first one, and put the subsequent ones in a modal, very much like ingredients
  • Option 3: Put them all in a collapsible section

If we load them by default, this asks the question of the tile server load

Part of

@teolemon teolemon added ✨ Feature Features or enhancements to Open Food Facts server Product Page 🗺️ Maps 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near- labels Jun 29, 2020
@hangy hangy added this to To Do in Server via automation Jun 29, 2020
@hangy
Copy link
Member

hangy commented Jun 29, 2020

I'd like a mock of the desktop+mobile view of this. How important should the map be in comparison to the product image? Also, why should it be a modal window?

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 14, 2021
@teolemon teolemon added the 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels label Aug 20, 2021
@teolemon
Copy link
Member Author

teolemon commented Jan 6, 2022

fixed

@teolemon teolemon closed this as completed Jan 6, 2022
Server automation moved this from To Do to Done Jan 6, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
✨ Feature Features or enhancements to Open Food Facts server 📖 Knowledge Panels https://wiki.openfoodfacts.org/Knowledge_panels 🗺️ Maps mockup-required 📍🏭 Packager codes https://blog.openfoodfacts.org/en/news/discover-what-food-products-are-made-near-you-with-made-near- Product Page ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
No open projects
Server
  
Done
Development

No branches or pull requests

2 participants