Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Some products have a different value for lang and lc #4435

Open
Tracked by #8049 ...
stephanegigandet opened this issue Oct 28, 2020 · 7 comments
Open
Tracked by #8049 ...

Some products have a different value for lang and lc #4435

stephanegigandet opened this issue Oct 28, 2020 · 7 comments
Assignees
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🌍 Multilingual products Product name, Generic name, Ingredients, Packaging text are multilingual fields. ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@stephanegigandet
Copy link
Contributor

stephanegigandet commented Oct 28, 2020

What

Part of

@stephanegigandet stephanegigandet added the 🐛 bug This is a bug, not a feature request. label Oct 28, 2020
@svensven
Copy link
Contributor

Here's another one: https://us.openfoodfacts.org/api/v0/product/4970077115289.json?rev=32
Saving it, but not deliberately changing anything language related, made them the same again: https://us.openfoodfacts.org/api/v0/product/4970077115289.json?rev=33

@aleene
Copy link
Contributor

aleene commented Oct 28, 2020

To copy some ideas from Slack. The query and json should be able to encode the following situation.

I would like to show my greek friend on my english device, the dutch products sold in Belgium. Any relevant information will be translated to greek.

@stephanegigandet
Copy link
Contributor Author

I think the issue of the products with lc != lang comes from the import of the USDA or producers data. It can change the lc field value without changing the lang value.

@stephanegigandet stephanegigandet self-assigned this Oct 28, 2020
@aleene
Copy link
Contributor

aleene commented Oct 28, 2020

In a query this would imply:

  • domain gives the product from Belgium
  • lang=nl, gives the dutch products
  • lc=el, any translatable fields (allergens, ingredients, attributes) will be in greek.

@svensven
Copy link
Contributor

svensven commented Oct 28, 2020

can't you already do that sort of thing with https://be-el.openfoodfacts.org/cgi/search.pl?action=process&tagtype_0=languages&tag_contains_0=contains&tag_0=en:dutch ?

Ah. it translates on the site, but not in the json.

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Jan 27, 2021
@teolemon teolemon added 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🌍 Multilingual products Product name, Generic name, Ingredients, Packaging text are multilingual fields. and removed ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. labels Jul 19, 2021
@teolemon
Copy link
Member

I clarified @stephanegigandet 's original example (that got fixed) by adding the field parameter.

Copy link
Contributor

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 10, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🧽 Data quality https://wiki.openfoodfacts.org/Quality 🌍 Multilingual products Product name, Generic name, Ingredients, Packaging text are multilingual fields. ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To discuss and validate
Development

No branches or pull requests

4 participants