Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Parse 'with other natural flavouring' #4666

Open
Tracked by #9096
Ban3 opened this issue Dec 23, 2020 · 3 comments
Open
Tracked by #9096

Parse 'with other natural flavouring' #4666

Ban3 opened this issue Dec 23, 2020 · 3 comments
Assignees
Labels
🐛 bug This is a bug, not a feature request. 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.

Comments

@Ban3
Copy link
Contributor

Ban3 commented Dec 23, 2020

What

natural X flavouring with other natural flavouring is a common ingredient combination. Currently, some of these are defined in the ingredients taxonomy, but detecting all possible combinations in the ingredients parser would be preferable.

Examples in some languages:
en
de
es
fr

Part of

@Ban3 Ban3 added 🐛 bug This is a bug, not a feature request. 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis labels Dec 23, 2020
@jolesh jolesh self-assigned this Jan 14, 2021
@jolesh
Copy link
Contributor

jolesh commented Jan 14, 2021

So I need to make entries in the ingredient.pm that changes "natural [X] flavouring with other natural flavouring" to "natural [X] flavouring, other natural flavouring" or should I also remove the 'other'? @stephanegigandet can you give me a tip/hint how to deal with the variable part X?

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Apr 15, 2021
@stephanegigandet
Copy link
Contributor

I think the best way to address that is to change the preparse_ingredients_text() function in Ingredients.pm to change the ingredient text to what @jolesh suggests. "natural [X] flavouring with other natural flavouring" to "natural [X] flavouring, other natural flavouring"

@github-actions github-actions bot removed the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Apr 26, 2021
Copy link
Contributor

github-actions bot commented Feb 7, 2024

This issue has been open 90 days with no activity. Can you give it a little love by linking it to a parent issue, adding relevant labels and projets, creating a mockup if applicable, adding code pointers from https://github.com/openfoodfacts/openfoodfacts-server/blob/main/.github/labeler.yml, giving it a priority, editing the original issue to have a more comprehensive description… Thank you very much for your contribution to 🍊 Open Food Facts

@github-actions github-actions bot added the ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it. label Feb 7, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
🐛 bug This is a bug, not a feature request. 🥗🔍 Ingredients analysis https://wiki.openfoodfacts.org/Ingredients_Extraction_and_Analysis ⏰ Stale This issue hasn't seen activity in a while. You can try documenting more to unblock it.
Projects
Status: To do
Status: To discuss and validate
Development

No branches or pull requests

3 participants